Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Can't save 2 entities consecutively (React + manytomany) #13197

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Fix: Can't save 2 entities consecutively (React + manytomany) #13197

merged 1 commit into from
Dec 5, 2020

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Dec 4, 2020

Fix #13182


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert closed this Dec 4, 2020
@qmonmert qmonmert reopened this Dec 4, 2020
@pascalgrimaud
Copy link
Member

can you rewrite your commit text with more explicite ones plz ?

@ctamisier
Copy link
Contributor

It's a detail but I think it's better to have only one commit.
For me the test is bound to the fix. If you checkout this commit (the fix), I would like to have the test as well.

@qmonmert
Copy link
Contributor Author

qmonmert commented Dec 5, 2020

@pascalgrimaud done (rewrite commit)
@ctamisier done (just one commit)

Copy link
Member

@ruddell ruddell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes the issue, thanks @qmonmert

@pascalgrimaud pascalgrimaud merged commit a213bf7 into jhipster:main Dec 5, 2020
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't save 2 entities consecutively (React + manytomany)
4 participants