Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application base name question in Windows Command Prompt #13216

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

kaidohallik
Copy link
Contributor

Fixes #13215


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be easier for blueprints.

generators/app/prompts.js Show resolved Hide resolved
generators/app/index.js Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
@kaidohallik
Copy link
Contributor Author

Should be easier for blueprints.

Thanks for the suggestions @mshima. Tested and those worked and used suggestions.

@mshima mshima merged commit 95852df into jhipster:main Dec 7, 2020
@kaidohallik kaidohallik deleted the fix-base-name-windows branch December 8, 2020 06:49
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application base name question is unstable in Windows Command Prompt
3 participants