Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] Fix Angular Sonar coverage and security hotspots #13233

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

kaidohallik
Copy link
Contributor

Should fix Angular part of #13232


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member

Arg, it's not fixed yet, because of https://github.com/jhipster/generator-jhipster/runs/1529536946?check_suite_focus=true :-(

Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.7.0.1746:sonar (default-cli) on project jhipster-sample-application: The directory '/home/runner/work/generator-jhipster/generator-jhipster/app/ src/main/webapp/app/**/*.spec.ts' does not exist for Maven module tech.jhipster.sample:jhipster-sample-application:jar:0.0.1-SNAPSHOT. Please check the property sonar.tests -> [Help 1]

@kaidohallik
Copy link
Contributor Author

I'm looking at that.

@DanielFran
Copy link
Member

@kaidohallik Suggestion:

sonar.tests.inclusions=/*.spec.ts
sonar.exclusions=src/main/webapp/app/
/.spec.ts, src/main/webapp/content/**/., src/main/webapp/i18n/.js, target/classes/static/**/.

@kaidohallik
Copy link
Contributor Author

If I looked at SonarCloud docs then suggestion was to define tests locations in sonar.tests to get best result.
But if this will not work then sonar.exclusions is alternative solution.

@kaidohallik
Copy link
Contributor Author

Created fix in #13235, used sonar.tests and sonar.test.inclusions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants