Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entity model to entity folder in Angular #13248

Merged

Conversation

kaidohallik
Copy link
Contributor

After #13125 (comment) decided to resolve also point 1 in #13125 - this PR resolves that.

Enumerations: initial plan was to move shared/model/enumerations/ to model/ but after thinking came to the conclusion that entities/enumerations/ is better place and moved there:

  • avoids creating new subfolder to root folder
  • enumerations are coming with entities, so entities folder is the best fit for their location

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 52643ca into jhipster:main Dec 12, 2020
@kaidohallik kaidohallik deleted the refactor-model-location-angular branch December 13, 2020 03:10
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants