Fix some sonar analysis: Call Optional#isPresent() before accessing the value #13256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
avdev4j
reviewed
Dec 12, 2020
| @@ -56,5 +56,5 @@ _%> | |||
| <%_ } %> | |||
| })<% } %><% if (dto !== 'no') { %> | |||
| .map(<%= mapper %>::toDto)<% } %><% if (isService && !reactive) { %> | |||
| .get()<% } %>; | |||
| .orElse(null)<% } %>; | |||
There was a problem hiding this comment.
It sounds strange to return null after dealing with an optional, no?
Maybe throw an Exception or something like that will be better.
There was a problem hiding this comment.
I'd prefer to return the optional directly, and in Resource, instead of having:
Optional<ChipsDTO> result = Optional.ofNullable(chipsService.partialUpdate(chipsDTO));We'll have:
Optional<ChipsDTO> result = chipsService.partialUpdate(chipsDTO);There was a problem hiding this comment.
Oh yea for sure, so far better.
There was a problem hiding this comment.
ok guys, let's do this
DanielFran
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13232
Fix errors Call Optional#isPresent() before accessing the value
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.