Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] fixes for custom ids #13257

Merged
merged 2 commits into from
Dec 13, 2020
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 12, 2020

trackById and getSelected functions used to assume that id always exists.
Refactor to trackEntityByField format and getSelectedEntity.

Related to #7112.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima mentioned this pull request Dec 12, 2020
5 tasks
Copy link
Contributor

@kaidohallik kaidohallik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The only concern is that as now more than 1 track / getSelected is generated and those are uncovered by unit tests then test coverage decreases.
So if possible then it would be good to add unit tests for track / getSelected.

@mshima
Copy link
Member Author

mshima commented Dec 13, 2020

@kaidohallik done, I will merge so I can rebase the other PR.
Don't hesitate to ask for changes after merged.

@mshima mshima merged commit fafcbde into jhipster:main Dec 13, 2020
@mshima mshima deleted the skip_ci_angular_custom_id branch December 13, 2020 16:20
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants