Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk support #13262

Merged
merged 6 commits into from
Dec 13, 2020
Merged

Snyk support #13262

merged 6 commits into from
Dec 13, 2020

Conversation

pascalgrimaud
Copy link
Member

Related to #12441


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member Author

GitLab CI result:

snyk-gitlab-ci

@pascalgrimaud
Copy link
Member Author

Azure Pipelines result:

snyk-azure-pipelines

@pascalgrimaud
Copy link
Member Author

GitHub Actions result:

snyk-github-actions

@pascalgrimaud
Copy link
Member Author

CircleCI result:

snyk-circle-ci

@pascalgrimaud
Copy link
Member Author

Travis CI result:

snyk-travis-ci

@pascalgrimaud
Copy link
Member Author

Don't blame me if I didn't test Jenkins, as I don't use Jenkins any more and too lazy for installing, configuring and testing it
But the support with Jenkins is in this PR ! I'm feeling confident as I was helped by the post blog

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pascalgrimaud Trusting you on this 😀

@DanielFran DanielFran merged commit 10a6b90 into jhipster:main Dec 13, 2020
@pascalgrimaud
Copy link
Member Author

Thanks @DanielFran : that's why I added screenshots to show my tests, as it's very long to test all CI
But by doing this, I was able to test all @mshima's work with e2e tests in our CI-CD sub gen, and everything works well !

@mshima
Copy link
Member

mshima commented Dec 13, 2020

Great work @pascalgrimaud

@pascalgrimaud
Copy link
Member Author

same to you, @mshima !

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants