[angular] Add tests for HasAnyAuthorityDirective and refactor shared folder #13265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonmert
reviewed
Dec 14, 2020
| import { HasAnyAuthorityDirective } from './has-any-authority.directive'; | ||
|
|
||
| @Component({ | ||
| template: ` <div *<%= jhiPrefix %>HasAnyAuthority="'ROLE_ADMIN'" #content></div> `, |
There was a problem hiding this comment.
is it on purpose ?
+ `<div *<%= jhiPrefix %>HasAnyAuthority="'ROLE_ADMIN'" #content></div>`,
- ` <div *<%= jhiPrefix %>HasAnyAuthority="'ROLE_ADMIN'" #content></div> `,There was a problem hiding this comment.
That's how Prettier formats inline HTML. I prefer to keep Prettier formatting in templates.
DanielFran
approved these changes
Dec 14, 2020
|
@kaidohallik feel free to merge it. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
takeUntilfor subscription destroying as discussed in Angular: use more generic unsubcriptions mechanism #12867HasAnyAuthorityDirectivesharedroot folder then movingitem-counttopaginationandhas-any-authoritytoauthsubfolder (where this was also in v6)Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.