Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sonar <i> and <b> exclusions #13294

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

kaidohallik
Copy link
Contributor

As we are not using <i> any more for Font Awesome icons then we can enable BoldAndItalicTagsCheck in Sonar.
Replaced some <b> with <strong> to pass Sonar.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran
Copy link
Member

@kaidohallik Trusting you on this

@DanielFran DanielFran merged commit 31bf6d4 into jhipster:main Dec 15, 2020
@kaidohallik kaidohallik deleted the remove-sonar-i-b-exclusion branch December 16, 2020 06:24
@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants