Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone prettier registering and add option to ignore prettier errors. #13327

Merged
merged 2 commits into from
Dec 19, 2020

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 18, 2020

  • When using vue app using prompts, configuration must be ready when registering prettier.
    See include .vue files in prettier script #12639 (comment).
  • Files with prettier errors are not written to disk, making it more difficult to debug.
    Add option to ignore prettier errors, so the broken file is written to disk.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@DanielFran DanielFran merged commit 8bea6b6 into jhipster:main Dec 19, 2020
@mshima mshima deleted the skip_ci_vue_prettier branch December 19, 2020 01:41
@pascalgrimaud
Copy link
Member

Thanks @mshima , but on my side, it doesn't fix the issue yet, as there are still files in git add
I don't know if I explain well enough. See my screenshot:

Capture d’écran de 2020-12-19 09-33-16

@mshima
Copy link
Member Author

mshima commented Dec 19, 2020

Looking at the code and you like prompts 😄, I've assumed that it was prompt related only.
But it's not.

Husky hooks are not working for me. Probably I have to add scripts to bash profile.
So I need to run npm run prettier:format manually to reproduce.

Should be fixed at #13329.

@pascalgrimaud
Copy link
Member

ahaha yes, I find prompt is quicker, than writing JDL :)

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.0 milestone Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants