fix react websockets implementation #13334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add location hook to Routes component to send router location on change export sendActivity to enabling sending path from location hook only subscribe to tracker endpoint when user is an admin disconnect and unsubscribe on logout Fix jhipster#12729
|
@ruddell : if you feel confident, plz go ahead and merge it. So it will be included for JH v7 beta |
qmonmert
reviewed
Dec 19, 2020
| @@ -39,6 +39,9 @@ import PrivateRoute from 'app/shared/auth/private-route'; | |||
| import ErrorBoundaryRoute from 'app/shared/error/error-boundary-route'; | |||
| import PageNotFound from 'app/shared/error/page-not-found'; | |||
| import { AUTHORITIES } from 'app/config/constants'; | |||
| <%_ if (websocket === 'spring-websocket') { _%> | |||
| import { sendActivity } from "app/config/websocket-middleware"; | |||
There was a problem hiding this comment.
+ 'app/config/websocket-middleware'
- "app/config/websocket-middleware"🙂
|
Bug bounty claimed at https://opencollective.com/generator-jhipster/expenses/30309 |
|
@ruddell : approved |
|
I restarted the daily builds for React, and it seems not working with Protractor e2e and prod profile:
|
ruddell
added a commit
to ruddell/generator-jhipster
that referenced
this pull request
Dec 21, 2020
ruddell
added a commit
to ruddell/generator-jhipster
that referenced
this pull request
Dec 21, 2020
also remove unused onhashchange method related to jhipster#13334
5 tasks
ruddell
added a commit
that referenced
this pull request
Dec 21, 2020
also remove unused onhashchange method related to #13334
coderguy-tech
pushed a commit
to coderguy-tech/generator-jhipster
that referenced
this pull request
Jun 1, 2021
also remove unused onhashchange method related to jhipster#13334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12729
Please make sure the below checklist is followed for Pull Requests.