Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: Replace all cy.server() and cy.route() by cy.intercept() #13414

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Cypress: Replace all cy.server() and cy.route() by cy.intercept() #13414

merged 1 commit into from
Jan 7, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Jan 5, 2021

Fix #13345


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert marked this pull request as ready for review January 6, 2021 09:34
@qmonmert qmonmert closed this Jan 6, 2021
@qmonmert qmonmert reopened this Jan 6, 2021
@DanielFran DanielFran merged commit 0ad8bd1 into jhipster:main Jan 7, 2021
// Fix in future version of cypress
// => https://glebbahmutov.com/blog/cypress-intercept-problems/#no-overwriting-interceptors
// => https://github.com/cypress-io/cypress/issues/9302
// cy.wait('@settingsNotSave').then(({ request, response }) => expect(response.statusCode).to.equal(400));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if it's better to keep old logic and keep cy.intercept commented for now to don't loose coverage.

@pascalgrimaud pascalgrimaud added this to the 7.0.0-beta.1 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cypress] Replace all cy.server() and cy.route() by cy.intercept()
4 participants