Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null checks and public access modifier #13653

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

Falydoor
Copy link
Contributor

Fix #13471

image

I'm not too familiar with reactor so let me know if there is a better way to handle this null check:

        if (persistentEntity == null) {
            throw new IllegalArgumentException("Unable to retrieve persisted entity");
        }

Please make sure the below checklist is followed for Pull Requests.

@murdos
Copy link
Contributor

murdos commented Feb 18, 2021

@Falydoor : could you resolve the conflicts?

@Falydoor
Copy link
Contributor Author

@murdos: Sonar check after resolving the conflicts

image

@murdos murdos merged commit 9c26bb2 into jhipster:main Feb 18, 2021
@murdos
Copy link
Contributor

murdos commented Feb 18, 2021

@Falydoor : thanks :)

@Falydoor Falydoor deleted the fix-13471 branch February 18, 2021 18:31
@Falydoor
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@Falydoor : approved

@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A reactive monolith is not AAA in Sonar
3 participants