Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update commands usage #13663

Merged
merged 2 commits into from
Jan 22, 2021
Merged

update commands usage #13663

merged 2 commits into from
Jan 22, 2021

Conversation

deepu105
Copy link
Member


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented Jan 21, 2021

Worth noting:

  • fork/interactive only applies for jdl with multiples applications (eg: microservice).
  • Fork is default for all new applications. While if 1 application existed interactive is used.

@deepu105 deepu105 requested a review from mshima January 21, 2021 10:58
@deepu105
Copy link
Member Author

@mshima ah ok, I was running on top of existing app probably that's why I thought the default was changed. Let me clarify it in PR

cli/commands.js Outdated Show resolved Hide resolved
cli/commands.js Outdated Show resolved Hide resolved
cli/commands.js Outdated Show resolved Hide resolved
@deepu105
Copy link
Member Author

@mshima the descriptions should be good now

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielFran DanielFran merged commit 46003d5 into jhipster:main Jan 22, 2021
@deepu105 deepu105 deleted the jdl-update branch January 22, 2021 15:43
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants