Update transitive dependencies to fix vulnerabilities #13692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted package-lock.json and node_modules and then ran npm install - this updated transitive dependencies and fixed vulnerabilities reported by npm audit
mraible
approved these changes
Jan 22, 2021
|
I don't think the Spring Boot 2.4 upgrade will be complete before v7 GA, so I'm in favor of this fix. |
|
This is something we should do regularly, so very nice ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted
package-lock.jsonandnode_modulesand then rannpm install- this updated transitive dependencies and fixed vulnerabilities reported bynpm audit.Got idea from commit in Spring Boot 2.4 branch 259e9d7 - so if this is preferred then this PR can be closed.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.