Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonar code smell about assertThat #13694

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

kaidohallik
Copy link
Contributor

Sonar description below.

Consecutive AssertJ "assertThat" statements should be chained.
AssertJ assertions methods targeting the same object can be chained instead of using multiple assertThat. It avoids duplication and increases the clarity of the code.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Sonar description below.

Consecutive AssertJ "assertThat" statements should be chained.
AssertJ assertions methods targeting the same object can be chained instead of using multiple assertThat. It avoids duplication and increases the clarity of the code.
@pascalgrimaud pascalgrimaud merged commit 653f316 into jhipster:main Jan 23, 2021
@kaidohallik kaidohallik deleted the fix-sonar-assert-that branch January 24, 2021 06:42
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants