Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csv data for incremental changelog #13697

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Jan 23, 2021

Fixes #13688


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima changed the title Fix fake data for incremental changelog Fix csv data for incremental changelog Jan 23, 2021
@mshima mshima marked this pull request as ready for review January 24, 2021 10:31
@pascalgrimaud
Copy link
Member

Just tested and it works well
Thanks a lot @mshima

@pascalgrimaud pascalgrimaud merged commit 766a3fe into jhipster:main Jan 24, 2021
@mshima mshima deleted the skip_ci_incremental branch January 24, 2021 12:13
@mshima
Copy link
Member Author

mshima commented Jan 24, 2021

Great.

Csv wasn’t generated at all for jdl.
That’s the reason for the ci to pass.

@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental Changelog: update for fake-data
2 participants