Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export/import of otherModules property #13714

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

ruddell
Copy link
Member

@ruddell ruddell commented Jan 25, 2021

Exporting Application JDL containing otherModules (for example when a blueprint is used) results in a JDL with otherModules [[object Object]] which fails when attempting to import.

This PR aligns the logic related to the otherModules property with the blueprints property, which has the same format. With this change, apps generated with blueprints can export valid JDL.

I am not an expert with JDL parsing so any review is appreciated.

To reproduce (also happens with beta v7):

# setup
mkdir reproduction && cd reproduction
npm i generator-jhipster@6.10.5 generator-jhipster-quarkus@1.0.0
jhipster jdl --inline "application{ config{ blueprints [generator-jhipster-quarkus]} }" --skip-install

# export-jdl
# npm link generator-jhipster # if you want to use the main branch
jhipster export-jdl
cat jhipster.jdl | grep object

Please make sure the below checklist is followed for Pull Requests.

Exporting Application JDL containing `otherModules` (for example when a blueprint is used) results in a JDL with `otherModules [[Object object]]` which fails when attempting to import.

This PR aligns the logic of the `otherModules` property with the `blueprints` property, which has the same format. With this change, apps generated with blueprints can export valid JDL.
@MathieuAA
Copy link
Member

Thanks @ruddell :)

@MathieuAA MathieuAA merged commit a9a4cab into jhipster:main Jan 26, 2021
@ruddell ruddell deleted the fix-other-modules-export-jdl branch January 26, 2021 13:59
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
Exporting Application JDL containing `otherModules` (for example when a blueprint is used) results in a JDL with `otherModules [[Object object]]` which fails when attempting to import.

This PR aligns the logic of the `otherModules` property with the `blueprints` property, which has the same format. With this change, apps generated with blueprints can export valid JDL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants