-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cypress dashboard in CI/CD sub generator #13717
Add cypress dashboard in CI/CD sub generator #13717
Conversation
65efa0a
to
6312531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add npm test too plz?
Then, we need documentation too, to not forget for the next release |
✔️ I have ran a generation for GitHub Actions with an app without entities. https://github.com/FanchGadjo/test-jh-13716 |
Is something preventing this dev to be done on gitlab-ci as well ? |
@pascalgrimaud I have added documentation and tests to the TODO list @FanchGadjo It has been done for Gitlab too. Only Jenkins doesn't contain that. |
@@ -154,7 +154,7 @@ | |||
<%_ } _%> | |||
<%_ if (cypressTests) { _%> | |||
"e2e:cypress:headless": "<%= clientPackageManager %> run e2e:cypress -- --headless", | |||
"e2e:cypress": "cypress run --browser chrome", | |||
"e2e:cypress": "cypress run --browser chrome --record ${CYPRESS_ENABLE_RECORD:-false}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this portable?
Scripts starting with ci:
are not portable.
But for this script IMO it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question, I don't know. But I did not succeed on use arguments with the current "ci:" scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See original bug about this #12805.
Have you tried concurrently -k -s first "npm run ci:e2e:server:start" "npm run e2e:headless -- --record ${CYPRESS_ENABLE_RECORD:-false}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it but it doesn't work (If I remember I have already tested this before).
You can check logs here:
https://github.com/avdev4j/jhipster-cypress-dashboard/runs/1810120628?check_suite_focus=true
@avdev4j : can you solve the conflict plz ? so it can be merged |
dbadb94
to
ce7d1d2
Compare
close #13716
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.