Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress dashboard in CI/CD sub generator #13717

Merged
merged 4 commits into from
Feb 13, 2021

Conversation

avdev4j
Copy link
Contributor

@avdev4j avdev4j commented Jan 25, 2021

close #13716

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@avdev4j avdev4j marked this pull request as draft January 25, 2021 22:22
@avdev4j avdev4j marked this pull request as ready for review January 25, 2021 22:53
Copy link
Member

@pascalgrimaud pascalgrimaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add npm test too plz?

@pascalgrimaud
Copy link
Member

Then, we need documentation too, to not forget for the next release

@FanchGadjo
Copy link

✔️ I have ran a generation for GitHub Actions with an app without entities.

https://github.com/FanchGadjo/test-jh-13716
https://dashboard.cypress.io/projects/v9ab2j/runs/2/overview

@FanchGadjo
Copy link

Is something preventing this dev to be done on gitlab-ci as well ?

@avdev4j
Copy link
Contributor Author

avdev4j commented Jan 28, 2021

@pascalgrimaud I have added documentation and tests to the TODO list

@FanchGadjo It has been done for Gitlab too. Only Jenkins doesn't contain that.

@@ -154,7 +154,7 @@
<%_ } _%>
<%_ if (cypressTests) { _%>
"e2e:cypress:headless": "<%= clientPackageManager %> run e2e:cypress -- --headless",
"e2e:cypress": "cypress run --browser chrome",
"e2e:cypress": "cypress run --browser chrome --record ${CYPRESS_ENABLE_RECORD:-false}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this portable?
Scripts starting with ci: are not portable.
But for this script IMO it should be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, I don't know. But I did not succeed on use arguments with the current "ci:" scripts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See original bug about this #12805.
Have you tried concurrently -k -s first "npm run ci:e2e:server:start" "npm run e2e:headless -- --record ${CYPRESS_ENABLE_RECORD:-false}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it but it doesn't work (If I remember I have already tested this before).

You can check logs here:
https://github.com/avdev4j/jhipster-cypress-dashboard/runs/1810120628?check_suite_focus=true

Capture d’écran 2021-02-01 à 22 50 58

@pascalgrimaud
Copy link
Member

@avdev4j : can you solve the conflict plz ? so it can be merged

@pascalgrimaud pascalgrimaud merged commit 83c9601 into jhipster:main Feb 13, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cypress Dashboard integration in CI/CD generator
4 participants