-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade R2DBC implementation classes for spring boot 2.4 #13739
Conversation
Tests for a project without entities should pass. Currently working on single entity repositories. |
I still have to clean up imports and some constructor, but webflux sql tests are passing now. I'll continue tomorrow. |
@ecostanzi It seems that all tests are passing! I think the You could test some more databases by enabling them in the CI job for this branch. https://github.com/jhipster/generator-jhipster/blob/main/.github/workflows/webflux.yml#L142 I recommend using |
@mraible I think it's ready for the review. I added the tests as you suggested. I also tested it locally using blog-oauth2.jdl with the reactive option and it seems to work correctly. Feel free to suggest more tests if they're needed. |
Well done, @ecostanzi! 🙌 |
This comment has been minimized.
This comment has been minimized.
thanks @mshima I didn't noticed :/ |
Please merge when CI passes! |
With mariadb integration tests with testcontainers don't work, I disabled testcontainers. With mysql integration tests pass, but I noticed some e2e test failures that don't seem to be related to the backend. Have we ever seen them working? I saw that they were both been disabled for similar reasons(see 361fab2 and 6fcbb1e). |
I'm merging. If there are remaining issues, we can clean them up in the |
Fixes #13613
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.