Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade R2DBC implementation classes for spring boot 2.4 #13739

Merged
merged 12 commits into from
Jan 28, 2021

Conversation

ecostanzi
Copy link
Contributor

@ecostanzi ecostanzi commented Jan 26, 2021

Fixes #13613


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@ecostanzi ecostanzi marked this pull request as draft January 26, 2021 23:01
@ecostanzi
Copy link
Contributor Author

Tests for a project without entities should pass. Currently working on single entity repositories.

@ecostanzi
Copy link
Contributor Author

I still have to clean up imports and some constructor, but webflux sql tests are passing now. I'll continue tomorrow.

@mraible
Copy link
Contributor

mraible commented Jan 27, 2021

@ecostanzi It seems that all tests are passing! I think the npm test failure is caused by something else.

You could test some more databases by enabling them in the CI job for this branch.

https://github.com/jhipster/generator-jhipster/blob/main/.github/workflows/webflux.yml#L142

I recommend using sqllight for the entity property. That way, e2e tests are a bit faster.

@ecostanzi ecostanzi marked this pull request as ready for review January 27, 2021 19:17
@ecostanzi
Copy link
Contributor Author

@mraible I think it's ready for the review. I added the tests as you suggested. I also tested it locally using blog-oauth2.jdl with the reactive option and it seems to work correctly. Feel free to suggest more tests if they're needed.

@mraible
Copy link
Contributor

mraible commented Jan 27, 2021

Well done, @ecostanzi! 🙌

.github/workflows/webflux.yml Outdated Show resolved Hide resolved
.github/workflows/webflux.yml Outdated Show resolved Hide resolved
@mshima

This comment has been minimized.

@ecostanzi
Copy link
Contributor Author

thanks @mshima I didn't noticed :/

@mraible
Copy link
Contributor

mraible commented Jan 27, 2021

Please merge when CI passes!

@ecostanzi
Copy link
Contributor Author

With mariadb integration tests with testcontainers don't work, I disabled testcontainers. With mysql integration tests pass, but I noticed some e2e test failures that don't seem to be related to the backend. Have we ever seen them working? I saw that they were both been disabled for similar reasons(see 361fab2 and 6fcbb1e).

@mraible
Copy link
Contributor

mraible commented Jan 28, 2021

I'm merging. If there are remaining issues, we can clean them up in the spring-boot-2.4 branch.

@mraible mraible merged commit 6e0684b into jhipster:spring-boot-2.4 Jan 28, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
)

Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants