Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable metrics as a Protractor test #13754

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Disable metrics as a Protractor test #13754

merged 3 commits into from
Jan 29, 2021

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Jan 28, 2021

No description provided.

@mraible
Copy link
Contributor Author

mraible commented Jan 28, 2021

@@ -63,9 +63,9 @@ describe('administration', () => {
});
<%_ } _%>

<!-- This test tends to fail with Protractor, so we've disabled it. Please enable if it passes for you!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment is not correct, as it should be // or /* instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

@mraible
Copy link
Contributor Author

mraible commented Jan 29, 2021

Test run passed! ✅ 🕺

@mraible mraible merged commit 4cc07e1 into jhipster:main Jan 29, 2021
@mraible mraible deleted the protractor-disable-metrics branch January 29, 2021 01:01
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants