Handle custom primary key names in entity filtering #13767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation, and support UUID pk type too
mshima
requested changes
Jan 29, 2021
There was a problem hiding this comment.
To prevent regressions would be nice to add a copy of https://github.com/mshima/generator-jhipster/blob/main/test-integration/samples/jdl-entities/custom-id.jdl with filtering.
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
mshima
reviewed
Jan 30, 2021
mshima
reviewed
Jan 30, 2021
|
@mshima thanks for the fixes and for the merge! |
coderguy-tech
pushed a commit
to coderguy-tech/generator-jhipster
that referenced
this pull request
Jun 1, 2021
* Fix jhipster#13695 : Handle custom primary key names in the filtering implementation, and support UUID pk type too * Update generators/entity/index.js Co-authored-by: Marcelo Shima <marceloshima@gmail.com> * Convert Set to Array and add new entities for filtering * Fix invalid-id selection for Strings * Fix formatting * Change to put the unescaped value * Reduce entity’s name size * Make sure we are not adding false to the set * Lint fix Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13695 : Handle custom primary key names in the filtering impleme…
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.