-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate random password for initial okta login with heroku #13798
generate random password for initial okta login with heroku #13798
Conversation
4ff71be
to
7567458
Compare
Added a |
@atomfrede I tried to test this with your branch, but it fails to deploy to Heroku with the "build on Heroku" option. I think this is because jhipster-dependencies' SNAPSHOT is unavailable, I'm not sure.
I tried to run
One thing I noticed is the Maven command that's used on Heroku:
It seems like it could be a bit shorter, like:
|
Related: building locally seems to run all the tests too. It's probably a good practice, but not sure if it's necessary.
It'd be cool if you could create and deploy a JHipster app to Heroku in 2 minutes! |
@atomfrede I got it to work. I forgot you needed to run Here's what it currently says:
Can we change it to the following?
I could also see changing the initial question to It'd also be cool if the password could be a different color so it's more noticeable. You probably don't want it to be blue because then the user might think "Yes" is part of it. Maybe yellow? At the end, there's a NaN. Not sure what that should be. I'm using the |
Sure.
Need to check if we can use different colors for the prompts
The |
I tried again without Hazelcast and it worked. I like the "reset your password on first use flow!" Besides the other edits I suggested, it might be cool to spit out the credentials at the end. I'm not sure we need to tell them they'll need to change their password afterward.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atomfrede I would change the end messages to capitalize JHipster. There's a jhipster
in there.
c2b75a6
to
44eb227
Compare
Bounty claimed https://opencollective.com/generator-jhipster/expenses/33184 |
@atomfrede : approved |
…#13798) * generate random password for initial okta login with heroku closes jhipster#13768 * fix password prompt and display of login at the end * remove identity provider from prompt
This PR generates a random password for the initial okta login when using heroku. The password is printed to the console afterwards (or can be checked in configuration as before).
closes #13768
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.