Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .gitignore for VS Code #13836

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

egvimo
Copy link
Contributor

@egvimo egvimo commented Feb 4, 2021

Change .gitignore file to allow certain VS Code workspace files.

See #13715


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2021

CLA assistant check
All committers have signed the CLA.

Allow workspace files like settins.json or extensions.json
to be checked in by updating .gitignore file.

See jhipster#13715
Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @egvimo

@atomfrede atomfrede merged commit f41b058 into jhipster:main Feb 16, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
@egvimo egvimo deleted the feature/gitignore-vscode branch March 31, 2021 11:37
coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
Allow workspace files like settins.json or extensions.json
to be checked in by updating .gitignore file.

See jhipster#13715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants