Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getter and setter for entity patch #13838

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

pascalgrimaud
Copy link
Member

Using this JDL:

application {
  config {
    baseName burger
  }
  entities *
}

entity Beer {
  aBeer String
  bBeer String
}

dto * with mapstruct
service * with serviceClass

Then, you'll have this compilation failure:

INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  52.326 s
[INFO] Finished at: 2021-02-04T15:29:20+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project burger: Compilation failure: Compilation failure: 
[ERROR] /home/pgrimaud/tmp/17-burger/src/main/java/com/mycompany/myapp/service/BeerService.java:[60,32] cannot find symbol
[ERROR]   symbol:   method getABeer()
[ERROR]   location: variable beerDTO of type com.mycompany.myapp.service.dto.BeerDTO
[ERROR] /home/pgrimaud/tmp/17-burger/src/main/java/com/mycompany/myapp/service/BeerService.java:[61,54] cannot find symbol
[ERROR]   symbol:   method getABeer()
[ERROR]   location: variable beerDTO of type com.mycompany.myapp.service.dto.BeerDTO
[ERROR] /home/pgrimaud/tmp/17-burger/src/main/java/com/mycompany/myapp/service/BeerService.java:[64,32] cannot find symbol
[ERROR]   symbol:   method getBBeer()
[ERROR]   location: variable beerDTO of type com.mycompany.myapp.service.dto.BeerDTO
[ERROR] /home/pgrimaud/tmp/17-burger/src/main/java/com/mycompany/myapp/service/BeerService.java:[65,54] cannot find symbol
[ERROR]   symbol:   method getBBeer()
[ERROR]   location: variable beerDTO of type com.mycompany.myapp.service.dto.BeerDTO
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima mshima merged commit 1a7914d into jhipster:main Feb 4, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants