Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when embedded documents are used, which doesn't have primary key. #13865

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

gzsombor
Copy link
Member

@gzsombor gzsombor commented Feb 6, 2021

(which happens with the gradle-mongodb-react configuration )

https://github.com/hipster-labs/jhipster-daily-builds/runs/1843126537?check_suite_focus=true
The bug was introduced by #13824


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

 (which happens with the  gradle-mongodb-react configuration )
@gzsombor gzsombor requested a review from mshima February 6, 2021 20:17
@pascalgrimaud
Copy link
Member

Thanks so much @gzsombor for taking care of this daily build :-)

@pascalgrimaud pascalgrimaud merged commit dce4993 into jhipster:main Feb 6, 2021
@gzsombor gzsombor deleted the fix-gradle-mongodb-react branch February 6, 2021 20:53
@gzsombor
Copy link
Member Author

gzsombor commented Feb 6, 2021

Welcome! @mshima did the heavy work to actually understand and explain the issue to me 😄

@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 20, 2021
@kp-marczynski
Copy link

kp-marczynski commented May 9, 2021

@gzsombor, @pascalgrimaud issue still exists at version 7.0.1 when generating angular frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants