Fix template for Reactive with H2 #13946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalgrimaud
force-pushed
the
fix-template-reactive-h2
branch
from
bc0d768
to
9b077c3
Compare
DanielFran
requested changes
Feb 13, 2021
generators/client/templates/react/src/main/webapp/app/shared/layout/menus/admin.tsx.ejs
Outdated
Show resolved
Hide resolved
…ayout/menus/admin.tsx.ejs Co-authored-by: Daniel Franco <dandrfranco@gmail.com>
|
Thanks for your good eyes @DanielFran |
DanielFran
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #13868 and #13943
cc @atomfrede : there is no npm test about these configurations. That's why we didn't detect it. We should definitively add these config in npm test :-)
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.