Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for single entities #13975

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Feb 15, 2021

Fixes #13833


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@ecostanzi
Copy link
Contributor

ecostanzi commented Feb 19, 2021

It works! But it prompts Do you want to update the entity? This will replace the existing files for this entity, all your custom code will be overwritten for each entity. It should prompt it just for the first one.

This is what I got by trying to generate the Tag entity with jhipster entity Tag --single-entity (the other two entities are Blog and Post, i'm using this jdl)

EDIT: same behaviour (multiple prompts) also without using --single-entity.

single-entity

@pascalgrimaud
Copy link
Member

We really need to document all these new flags and options

@pascalgrimaud pascalgrimaud merged commit 74df42b into jhipster:main Feb 25, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 28, 2021
@mshima mshima deleted the skip_ci_single_entity branch March 2, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entity generation fails when when using --single-entity option
3 participants