Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Cassandra date-time JDL types with common-databases JDL types #14027

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Feb 21, 2021

  • Update JDL to enable enumerations with Cassandra. This is already supported by generator-jhipster since enable use of enumerations with Cassandra #10414
  • Unify Cassandra date-time JDL types with common-databases JDL types:
    • remove Date type, redundant with Instant type
    • add LocalDate type
    • add Duration type

Fixes #14026

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

This is already supported by generator-jhipster since jhipster#10414
- remove Date type, redundant with Instant type
- add LocalDate type
- add Duration type

Fixes jhipster#14026
@pascalgrimaud
Copy link
Member

Good job @murdos !

@murdos murdos mentioned this pull request Feb 24, 2021
1 task
@pascalgrimaud
Copy link
Member

@murdos :

@murdos
Copy link
Contributor Author

murdos commented Feb 24, 2021

@pascalgrimaud : thanks! It's all good now 😊

@pascalgrimaud pascalgrimaud merged commit 6fa371d into jhipster:main Feb 24, 2021
@murdos murdos deleted the cassandra-jdl-types branch February 24, 2021 21:26
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: unify Cassandra date-time JDL types with common-databases JDL types
2 participants