-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swagger for reactive gateway #14029
Add swagger for reactive gateway #14029
Conversation
Adding a bounty on this important part, as we can't do a new release without this |
...ators/server/templates/src/main/java/package/config/GatewaySwaggerResourcesProvider.java.ejs
Outdated
Show resolved
Hide resolved
...ators/server/templates/src/main/java/package/config/GatewaySwaggerResourcesProvider.java.ejs
Outdated
Show resolved
Hide resolved
...ators/server/templates/src/main/java/package/config/GatewaySwaggerResourcesProvider.java.ejs
Outdated
Show resolved
Hide resolved
...ators/server/templates/src/main/java/package/config/GatewaySwaggerResourcesProvider.java.ejs
Outdated
Show resolved
Hide resolved
@murdos I applied your suggestions, thank you |
Can you fix npm test plz? |
@pascalgrimaud when we get routes from spring cloud gateway, the uri scheme of each route is |
...ators/server/templates/src/main/java/package/config/GatewaySwaggerResourcesProvider.java.ejs
Outdated
Show resolved
Hide resolved
...ators/server/templates/src/main/java/package/config/GatewaySwaggerResourcesProvider.java.ejs
Outdated
Show resolved
Hide resolved
@nassimerrahoui : I got something working on my computer. I'm cleaning my code and will push it soon. Maybe tonight or tomorrow |
- refactoring + fix filter for consul - fix npm test - add condition on service discovery type - add reactive condition + merge generated files
e825b61
to
f343e38
Compare
I think it's finished. |
I tested your changes, it works, thank you @pascalgrimaud 👍 |
Thanks, so let's merge it |
@nassimerrahoui : don't forget to claim the bounty, you did almost all the work. I only helped to finish |
bounty claimed : https://opencollective.com/generator-jhipster/expenses/34847 |
Thanks for your help :) |
@nassimerrahoui : approved |
Swagger is still broken... |
Fix here #14204 |
Feature #13855 Swagger for reactive gateway
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.