Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swagger for reactive gateway #14029

Merged

Conversation

nassimerrahoui
Copy link
Contributor

@nassimerrahoui nassimerrahoui commented Feb 21, 2021

Feature #13855 Swagger for reactive gateway


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Feb 21, 2021
@pascalgrimaud
Copy link
Member

Adding a bounty on this important part, as we can't do a new release without this

@nassimerrahoui
Copy link
Contributor Author

@murdos I applied your suggestions, thank you

@pascalgrimaud
Copy link
Member

Can you fix npm test plz?
Can you tell us what doesn't work? JWT ? OAuth2? Both?

@nassimerrahoui
Copy link
Contributor Author

nassimerrahoui commented Feb 26, 2021

@pascalgrimaud when we get routes from spring cloud gateway, the uri scheme of each route is lb://serviceid and it cannot retreive swagger resources (lb://serviceid/swagger-resources) from these routes with JWT and OAuth2. I don't know if we can hit 'loadbalancer endpoint' with webclient.

@pascalgrimaud
Copy link
Member

@nassimerrahoui : I got something working on my computer. I'm cleaning my code and will push it soon. Maybe tonight or tomorrow

nassimerrahoui and others added 4 commits February 27, 2021 19:03
- refactoring + fix filter for consul
- fix npm test - add condition on service discovery type
- add reactive condition + merge generated files
@pascalgrimaud pascalgrimaud marked this pull request as ready for review February 27, 2021 18:28
@pascalgrimaud
Copy link
Member

I think it's finished.
Can you test this PR with these new changes plz @nassimerrahoui ?

@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 28, 2021
@nassimerrahoui
Copy link
Contributor Author

nassimerrahoui commented Feb 28, 2021

I tested your changes, it works, thank you @pascalgrimaud 👍

@pascalgrimaud
Copy link
Member

Thanks, so let's merge it

@pascalgrimaud pascalgrimaud merged commit a4e8fe5 into jhipster:main Feb 28, 2021
@pascalgrimaud
Copy link
Member

@nassimerrahoui : don't forget to claim the bounty, you did almost all the work. I only helped to finish

@nassimerrahoui
Copy link
Contributor Author

@nassimerrahoui
Copy link
Contributor Author

nassimerrahoui commented Feb 28, 2021

Thanks for your help :)

@pascalgrimaud
Copy link
Member

@nassimerrahoui : approved

@pascalgrimaud
Copy link
Member

Swagger is still broken...
Can you have a look on this plz @nassimerrahoui ?

@nassimerrahoui
Copy link
Contributor Author

Fix here #14204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants