Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Refactor router-link to remove tag for v-slot #14030

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

swarajsaaj
Copy link
Contributor

Refactor router-link tag to v-slot for future support https://next.router.vuejs.org/guide/migration/#removal-of-event-and-tag-props-in-router-link

Fix #13974


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Thanks @swarajsaaj for the contribution

@atomfrede
Copy link
Member

The failing tests are unrelated (ngx)

@atomfrede atomfrede merged commit 44453a1 into jhipster:main Feb 22, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Feb 28, 2021
coderguy-tech pushed a commit to coderguy-tech/generator-jhipster that referenced this pull request Jun 1, 2021
* [Vue] Refactor router-link to remove tag for v-slot

Refactor router-link tag to v-slot for future support https://next.router.vuejs.org/guide/migration/#removal-of-event-and-tag-props-in-router-link

Fix jhipster#13974

* Remove unused code

Fix jhipster#13974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning when using vue
3 participants