Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OneToMany id bug in react entity validation form #14121

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix: OneToMany id bug in react entity validation form #14121

merged 1 commit into from
Mar 4, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Mar 1, 2021

Fix #13989


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert changed the title Fix: OneToMany id bug in react entity validation form WIP Fix: OneToMany id bug in react entity validation form Mar 1, 2021
@qmonmert qmonmert marked this pull request as draft March 1, 2021 20:19
@qmonmert qmonmert changed the title WIP Fix: OneToMany id bug in react entity validation form Fix: OneToMany id bug in react entity validation form Mar 1, 2021
@qmonmert qmonmert closed this Mar 2, 2021
@qmonmert qmonmert reopened this Mar 2, 2021
@qmonmert qmonmert marked this pull request as ready for review March 3, 2021 17:06
@pascalgrimaud
Copy link
Member

As I'm not a React expert, trusting you on this :)

@pascalgrimaud pascalgrimaud merged commit c322061 into jhipster:main Mar 4, 2021
@deepu105
Copy link
Member

deepu105 commented Mar 5, 2021

I'm wondering how this passed the CI as there was clearly a TS error and #14163 . I'm gonna do a PR to fix it, but we need to check why this didn't fail the CI

@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 5, 2021

@deepu105 what "TS error" ? in my PR ?

@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 5, 2021

@deepu105 there is a problem with this PR ? 🤔

@deepu105 deepu105 mentioned this pull request Mar 5, 2021
5 tasks
@deepu105
Copy link
Member

deepu105 commented Mar 5, 2021

@qmonmert check this #14181

@deepu105
Copy link
Member

deepu105 commented Mar 5, 2021

@pascalgrimaud I figured out why the TS error was not caught by CI, the error happens only when your entity name is already plural, like CustomerDetails for example. May be we should add an entity with same spelling for singular/plural

@qmonmert
Copy link
Contributor Author

qmonmert commented Mar 5, 2021

#14181

ok it was a bug before this PR

@pascalgrimaud
Copy link
Member

Oh nice catch @deepu105. Agree, we should improve our CI

@pascalgrimaud pascalgrimaud added this to the v7.0.0-beta.2 milestone Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneToMany id bug in react entity validation form
3 participants