Add id to PUT requests. #14251
Merged
Add id to PUT requests. #14251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pascalgrimaud do you think we should keep backward compatibility with PUT without id? |
|
@mshima : IMO, no need |
pascalgrimaud
requested changes
Mar 9, 2021
|
🤔 there are no PUT tests in Gatling. |
|
Oh my bad, so forget my comment ahaha |
pascalgrimaud
approved these changes
Mar 9, 2021
|
@pascalgrimaud no problem I will try to add. |
|
I don't think it is needed as @atomfrede is working on gatling. My comment was to not forget this part in case of it is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14139.
This PR changes PUT requests to require id in the Url to match GET requests.
Following discussions of HTTP specification.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.