Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure generators using derived properties #14291

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Mar 12, 2021

Contributes to #14235, just to give an overview of what it looks like on a generator


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl Tcharl changed the title azure generators using derived properties WIP - azure generators using derived properties Mar 12, 2021
@Tcharl Tcharl force-pushed the constantref branch 3 times, most recently from 19e36ab to a17516d Compare March 13, 2021 14:16
@Tcharl Tcharl changed the title WIP - azure generators using derived properties azure generators using derived properties Mar 13, 2021
generators/ci-cd/index.js Outdated Show resolved Hide resolved
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

generators/generator-base.js Outdated Show resolved Hide resolved
generators/generator-base.js Outdated Show resolved Hide resolved
generators/generator-base.js Outdated Show resolved Hide resolved
generators/client/index.js Outdated Show resolved Hide resolved
generators/ci-cd/index.js Outdated Show resolved Hide resolved
generators/azure-app-service/index.js Outdated Show resolved Hide resolved
generators/generator-base.js Outdated Show resolved Hide resolved
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the duplicated load at client.

generators/client/index.js Outdated Show resolved Hide resolved
@Tcharl
Copy link
Contributor Author

Tcharl commented Mar 16, 2021

Many thanks for your help Marcello, I did learn many things, thanks to your support

@Tcharl Tcharl merged commit 1cb45c3 into jhipster:main Mar 17, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants