Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mapstruct in patch request #14292

Merged
merged 8 commits into from
Mar 14, 2021
Merged

Use mapstruct in patch request #14292

merged 8 commits into from
Mar 14, 2021

Conversation

PiperDing
Copy link
Contributor

@PiperDing PiperDing commented Mar 13, 2021 •
edited by DanielFran

Fix #14033
Fix #14290

  1. move partialUpdate function to mapstruct
  2. generate the patch request code at client
  3. add ID parameter to PATCH

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@PiperDing PiperDing mentioned this pull request Mar 13, 2021
Closed
1 task
@mshima
Copy link
Member

mshima commented Mar 13, 2021

@PiperDing can you add id parameter to PATCH? See #14290.

@PiperDing
Copy link
Contributor Author

@mshima ok, I will do it

@mshima
Copy link
Member

mshima commented Mar 13, 2021

@mshima ok, I will do it

Thanks

change reactive patch uri
34636dc 
fix bug: http code 405 in reactive project

this is a fix
@PiperDing
Copy link
Contributor Author

@mshima The optimization is complete

@DanielFran
Copy link
Member

@PiperDing many thanks for the contribution!

@DanielFran DanielFran merged commit cf00b30 into jhipster:main Mar 14, 2021
mshima
mshima reviewed Mar 14, 2021
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PiperDing great work and congrats for the first contribution.

@pascalgrimaud pascalgrimaud added this to the v7.0.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima left review comments

@DanielFran DanielFran DanielFran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Current PATCH method doesn't follows HTTP specification. optimize PATCH request in v7
5 participants
@PiperDing @CLAassistant @mshima @DanielFran @pascalgrimaud