OIDC /userinfo lookup improvements #14307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tcharl
reviewed
Mar 13, 2021
| (generator.applicationType === 'monolith' || | ||
| generator.applicationType === 'microservice' || | ||
| generator.applicationType === 'gateway'), | ||
| condition: generator => !generator.reactive && generator.authenticationType === 'oauth2' && generator.applicationType === 'monolith', |
There was a problem hiding this comment.
This feature was never implemented for WebFlux. Since our gateway is now WebFlux-only, it doesn't make sense to include this. Adding it to WebFlux is being tracked by #13461.
There was a problem hiding this comment.
This explains that. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes things so microservices don't have a
CustomClaimConverterfor looking up a user's attributes. It should only be at the gateway or monolith level. Since it wasn't implemented for reactive, this means it only applies to non-reactive monoliths now. FYI @Falydoor.Please make sure the below checklist is followed for Pull Requests.