Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes angular duplicated navbar element generation. #14391

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Mar 20, 2021

Allows to customize already applied needled detection.

  • prettierAware: prettier formatting takes line width into account.
    Needles must test for dynamic empty space/line breaks count.
  • regexp: custom detection when testing the entire content is not a good approach, and there is a simpler test to use.

Related to #14388.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as draft March 20, 2021 11:58
@mshima mshima force-pushed the skip_ci_needle_angular branch 2 times, most recently from 4499e60 to 178436f Compare March 20, 2021 12:31
@mshima mshima changed the title Fixes needle detection with whitespace prettier changes. Fixes angular duplicated navbar element generation. Mar 20, 2021
@mshima mshima marked this pull request as ready for review March 20, 2021 13:14
@mshima
Copy link
Member Author

mshima commented Mar 20, 2021

Switched to use routerLink to check for existing needles, doesn't make sense to have 2 identical routerLink.
Otherwise we can create an id.

@pascalgrimaud pascalgrimaud merged commit c4e6e19 into jhipster:main Mar 20, 2021
@pascalgrimaud pascalgrimaud added this to the v7.0.0 milestone Mar 20, 2021
@mshima mshima deleted the skip_ci_needle_angular branch April 20, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants