Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for duplicated needle and fix css needle. #14394

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Mar 20, 2021

  • bug-fix: dropped pipeline-pipe due to not handling errors correctly.
  • bug-fix: when adding styles, ignore comments when testing if it's already included.
  • test added: when adding same needles twice, they should not be added and files should not change.
  • misc improvements to needle tests.

Closes #14388.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member

@mshima : are you confident enough, for merging this ?
The release is for tomorrow and I think we need this bug fix

@mshima
Copy link
Member Author

mshima commented Mar 20, 2021

@pascalgrimaud yes.
The first change is important due to prettier error handling. IMO It’s well tested (every test tests it 😄).
The second is a very small bug-fix.

Merging.

@mshima mshima merged commit 5b9204d into jhipster:main Mar 20, 2021
@mshima mshima deleted the skip_ci_needle_angular2 branch March 20, 2021 18:56
@pascalgrimaud
Copy link
Member

Thanks a lot, don't forget your bounty

@pascalgrimaud pascalgrimaud added this to the v7.0.0 milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Angular] Navbar not correctly updated when entity is created/updated
2 participants