Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'publish docker' stage in Jenkinsfile #14550

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

egvimo
Copy link
Contributor

@egvimo egvimo commented Apr 1, 2021

Updating the CI-CD generator Jenkinsfile.

  • This fixes the node install bug for Gradle
  • use prod builds
  • and use the same commands described in the docs.

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima
Copy link
Member

mshima commented Apr 25, 2021

We have #13531 open to decide which command to use for docker.
It should be used here too.

@egvimo
Copy link
Contributor Author

egvimo commented May 6, 2021

We have #13531 open to decide which command to use for docker.
It should be used here too.

Done.

@egvimo
Copy link
Contributor Author

egvimo commented Jun 17, 2021

We have #13531 open to decide which command to use for docker.
It should be used here too.

@mshima The discussion is now closed, but I don't quite know what the outcome is. Should I use compile and update the PR?

@mshima
Copy link
Member

mshima commented Jun 17, 2021

@egvimo I think the correct was to use package or compile, but since the PR is not merged and the documentation still uses verify, you should use verify for now.

You will probably need to updated test snapshots for tests to pass.

@egvimo
Copy link
Contributor Author

egvimo commented Jun 18, 2021

@mshima I have updated the command and the tests.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima
Copy link
Member

mshima commented Jun 18, 2021

@pascalgrimaud are you already doing do release?

@pascalgrimaud
Copy link
Member

Everything is ready on my computer but I'll do it this afternoon.
So this one can be merged, as it looks safe

@pascalgrimaud pascalgrimaud merged commit c8e9679 into jhipster:main Jun 18, 2021
@egvimo egvimo deleted the feature/jenkins-ci-jib branch June 18, 2021 10:55
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants