use constants in generator docker

[Tcharl]

contributes to generator understanding

Use constants in generator docker

Please make sure the below checklist is followed for Pull Requests.

• All continuous integration tests are green
• Tests are added where necessary
• jhipster-online was updated if necessary
• Documentation is added/updated where necessary
• Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

[mshima]

Would be nice if you limit PRs to ~20 files.
It will be a lot easier.

[Tcharl]

@mshima better now? FYI, I removed the elasticSearchFalse in favour of testing elasticSearch as it is set to false if disabled

[mshima]

The entity* generators needs more work at derived properties due to Microservice support.
Some config is loaded from the gateway, others from Microservice.
Others seems ok.

IMO you should remove derived properties from entities at this PR, just use constants.
Microservice support is really complicated.

[Tcharl]

This entity-client generator's code is crazy: so much nifty details everywhere...

[Tcharl]

@mshima or @pascalgrimaud can you take a look and maybe quick (as any modification on the angular entity part will lead to a conflict)? I know it's tough and I'm sorry for that, but I think I found the elegant way to achieve it and now templates are way more clean.
I would like to continue on that refactoring to be globally applied and I guess we'll then have a way more maintainable codebase.

I guess that the overall refacto will need two or three more full refinement but as it will only be at the js level after the first pass we'll be able to make something way more scalable and modular (I can't wait to split up that 2.6 thousand-line BaseGenerator class :-p)

[mshima]

@Tcharl last commit is not ok, or it fixes bugs, not sure. The generated code is not identical anymore.

While testing, I've realized that micro service support was already buggy for entity due to a racing condition. We will fix this later.

Revert last commit and merge.
Create a new PR with the last commit.

[mshima]

@Tcharl I've just merged #14561 and realized that I've replaced builtToolUndefined with buildTookUnknown, that you may be using here.

Feel free to add it again.

[Tcharl]

Sorry @mshima but I don't understand your remark: should I only accept your change and that's it?
What is different compared to previous generation? It shouldn't have modified anything (maybe some carriage return but should be the only difference).

[mshima]

Sorry @mshima but I don't understand your remark: should I only accept your change and that's it?

Yes, it stopped recalculating jhiPrefixDashed.

What is different compared to previous generation? It shouldn't have modified anything (maybe some carriage return but should be the only difference).

See the builds bellow.
Builds taking more than 6min means that the source code have changed.
Eg. go to details of Angular / ngx-default (pull_request) at Merge: merge project diff step:

You will see the diff:

@@ -868,6 +868,13 @@
             >
               This field is required.
             </small>
+            <small
+              class="form-text text-danger"
+              [hidden]="!editForm.get('localDateRequiredTom')?.errors?.ZonedDateTimelocal"
+              myPrefixTranslate="entity.validation.ZonedDateTimelocal"
+            >
+              This field should be a date and time.
+            </small>
           </div>
         </div>

[Tcharl]

I got the one you mentioned :-) and thank you for the TIPs!. It was a bug on my side (I used Temporal which included ZonedDateTime, LocalDate and Instant instead of Timed, which only includes ZonedDateTime and Instant).

Let's rebuild it and see if things are always modified: fingers crossed! Anyway, the review is still welcome: I'll hope I don't have included other side effect

[Tcharl]

So, good to go? Ready for the next round (I promise, it will be less than 20 files this time ;-))

[pascalgrimaud]

Go ahead @Tcharl !