Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypress] Remove unnecessary page visits and be verbose on skipped tests. #14568

Merged
merged 4 commits into from
Apr 3, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Apr 3, 2021

  • Add copyright headers.
  • Remove unnecessary page visits
  • Be verbose on skipped tests
  • Reduces runtime 20-30%

Related to #14441


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud
Copy link
Member

@mshima : I think it is still possible to launch npm run cypress and select each tests to be run individually ?

@pascalgrimaud
Copy link
Member

ok, just tested, it works well, excepting another issue with duplicated navbar (for Vue application), with double same entries (I used jhipster entity subgenerator)

Capture d’écran de 2021-04-03 10-09-53

@pascalgrimaud pascalgrimaud merged commit 907456d into jhipster:main Apr 3, 2021
@mshima mshima deleted the skip_ci_cypress2 branch April 3, 2021 10:17
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants