Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Minor style code #14575

Merged
merged 1 commit into from
Apr 3, 2021
Merged

[Angular] Minor style code #14575

merged 1 commit into from
Apr 3, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Apr 3, 2021

Improve some code style


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@qmonmert qmonmert closed this Apr 3, 2021
@qmonmert qmonmert reopened this Apr 3, 2021
Copy link
Contributor

@kaidohallik kaidohallik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank lines between library and internal module imports are intentional.
Other changes are OK.

@@ -18,6 +18,7 @@
-%>
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those empty lines are intentional, those are separating library and application internal imports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

@@ -18,6 +18,7 @@
-%>
import { Injectable } from '@angular/core';
import { NgbPaginationConfig } from '@ng-bootstrap/ng-bootstrap';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

@@ -20,6 +20,7 @@ import { Injectable, SecurityContext, NgZone } from '@angular/core';
import { DomSanitizer } from '@angular/platform-browser';
<%_ if (enableTranslation) { _%>
import { TranslateService } from '@ngx-translate/core';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

@@ -19,6 +19,7 @@
import { Component, OnInit } from '@angular/core';
import { Observable } from 'rxjs';
import { map } from 'rxjs/operators';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

@@ -19,6 +19,7 @@
import { Component, ViewChild, OnInit, AfterViewInit, ElementRef } from '@angular/core';
import { FormBuilder, Validators } from '@angular/forms';
import { Router } from '@angular/router';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

@@ -17,6 +17,7 @@
limitations under the License.
-%>
import { Route } from '@angular/router';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

@@ -17,6 +17,7 @@
limitations under the License.
-%>
import { NgModule } from '@angular/core';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional blank line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes intentional

Copy link
Contributor

@kaidohallik kaidohallik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misread changes, I interpreted added lines as deleted lines. Everything is OK. Thanks @qmonmert!

@kaidohallik kaidohallik merged commit 6d6c3b9 into jhipster:main Apr 3, 2021
@qmonmert
Copy link
Contributor Author

qmonmert commented Apr 3, 2021

I misread changes, I interpreted added lines as deleted lines. Everything is OK. Thanks @qmonmert!

ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants