-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Angular] Minor style code #14575
[Angular] Minor style code #14575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blank lines between library and internal module imports are intentional.
Other changes are OK.
@@ -18,6 +18,7 @@ | |||
-%> | |||
import { NgModule } from '@angular/core'; | |||
import { RouterModule } from '@angular/router'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those empty lines are intentional, those are separating library and application internal imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
@@ -18,6 +18,7 @@ | |||
-%> | |||
import { Injectable } from '@angular/core'; | |||
import { NgbPaginationConfig } from '@ng-bootstrap/ng-bootstrap'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
@@ -20,6 +20,7 @@ import { Injectable, SecurityContext, NgZone } from '@angular/core'; | |||
import { DomSanitizer } from '@angular/platform-browser'; | |||
<%_ if (enableTranslation) { _%> | |||
import { TranslateService } from '@ngx-translate/core'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
@@ -19,6 +19,7 @@ | |||
import { Component, OnInit } from '@angular/core'; | |||
import { Observable } from 'rxjs'; | |||
import { map } from 'rxjs/operators'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
@@ -19,6 +19,7 @@ | |||
import { Component, ViewChild, OnInit, AfterViewInit, ElementRef } from '@angular/core'; | |||
import { FormBuilder, Validators } from '@angular/forms'; | |||
import { Router } from '@angular/router'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
@@ -17,6 +17,7 @@ | |||
limitations under the License. | |||
-%> | |||
import { Route } from '@angular/router'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
@@ -17,6 +17,7 @@ | |||
limitations under the License. | |||
-%> | |||
import { NgModule } from '@angular/core'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misread changes, I interpreted added lines as deleted lines. Everything is OK. Thanks @qmonmert!
ok :) |
Improve some code style
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.