Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[angular] Polish, add tests and improve automatic language change logic #14627

Merged

Conversation

kaidohallik
Copy link
Contributor

Uses similar style for SessionStorageService and LocalStorageService variable names:

  • using sessionStorageService and localStorageService everywhere
  • previously also sessionStorage, $sessionStorage, localStorage and $localStorage was used, names $sessionStorage and $localStorage are probably AngularJs relicts

Adds more tests to AccountService.

Improves automatic language change logic:

  • previously when navigating away and back to application then chosen language was reapplied only if valid authentication existed
  • now previously chosen language is reapplied also if user is not authenticated

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielFran DanielFran merged commit 6ed2221 into jhipster:main Apr 9, 2021
@kaidohallik kaidohallik deleted the improve-angular-account-service branch April 9, 2021 14:16
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants