Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Sonar #14701

Merged
merged 2 commits into from
Apr 17, 2021
Merged

[Vue] Sonar #14701

merged 2 commits into from
Apr 17, 2021

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Apr 17, 2021

Fix sonar issues:

  • Replace this trivial promise with Promise.resolve
  • Expected a for-of loop instead of a for loop with this simple iteration

Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima mshima merged commit e57796b into jhipster:main Apr 17, 2021
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants