Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constants in entity-server #14703

Merged
merged 5 commits into from
Apr 21, 2021
Merged

use constants in entity-server #14703

merged 5 commits into from
Apr 21, 2021

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Apr 18, 2021

Contributes to #14235


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl Tcharl marked this pull request as draft April 18, 2021 11:41
@Tcharl Tcharl force-pushed the constantref branch 4 times, most recently from 10ef20c to 7a6cc7c Compare April 19, 2021 07:45
@Tcharl Tcharl marked this pull request as ready for review April 19, 2021 15:06
@Tcharl Tcharl marked this pull request as draft April 19, 2021 15:19
@Tcharl Tcharl marked this pull request as ready for review April 19, 2021 18:49
generators/entity/index.js Outdated Show resolved Hide resolved
utils/entity.js Outdated Show resolved Hide resolved
utils/entity.js Outdated Show resolved Hide resolved
@Tcharl Tcharl force-pushed the constantref branch 2 times, most recently from e8badc3 to d1da162 Compare April 21, 2021 11:22
Tcharl and others added 2 commits April 21, 2021 13:59
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Co-authored-by: Marcelo Shima <marceloshima@gmail.com>
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants