Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where 401 errors trigger a notification #14764

Merged
merged 1 commit into from
May 11, 2021

Conversation

emilpaw
Copy link
Contributor

@emilpaw emilpaw commented Apr 24, 2021

the login popup shows an error message therefore a notification is not needed

Fix #14738

Please make sure the below checklist is followed for Pull Requests.

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2021

CLA assistant check
All committers have signed the CLA.

the login popup shows an error message therefore a notification is not needed

Fix jhipster#14738
@emilpaw emilpaw changed the title fix bug where 401 errors trigger a notification Fix bug where 401 errors trigger a notification Apr 24, 2021
Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and congrats to your first PR!

@atomfrede atomfrede merged commit dc902af into jhipster:main May 11, 2021
@atomfrede
Copy link
Member

@emilpaw Don't forget to claim your Bounty

@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@emilpaw emilpaw deleted the fix-401-notification branch March 6, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No translation for 401 errors (error.http.401 missing)
4 participants