Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow env variables to override Cypress credentials #14815

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Allow env variables to override Cypress credentials #14815

merged 1 commit into from
Apr 28, 2021

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Apr 27, 2021 •
edited

With Protractor, we allow username/password to be overridden by environment variables. We should do the same for Cypress.

Please make sure the below checklist is followed for Pull Requests.

mshima
mshima approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshima mshima merged commit 595fe86 into jhipster:main Apr 28, 2021
@mraible mraible deleted the cypress-credentials branch May 11, 2021 19:41
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshima mshima mshima approved these changes

Assignees
No one assigned
Labels
area: enhancement 🔧 theme: front theme: tests
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mraible @mshima @DanielFran @pascalgrimaud