Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prompt for the Azure location #14956

Merged
merged 1 commit into from
May 11, 2021
Merged

Conversation

jdubois
Copy link
Member

@jdubois jdubois commented May 11, 2021

Fix #14863

@jdubois jdubois merged commit 37ba542 into jhipster:main May 11, 2021
@jdubois jdubois deleted the fix-14863 branch May 11, 2021 18:05
@mraible
Copy link
Contributor

mraible commented May 12, 2021

This issue makes me wonder, do we need JDL support for this?

@MathieuAA
Copy link
Member

MathieuAA commented May 14, 2021

There's currently no "Azure deployment"-related code in the JDL, but yes: I think we want JDL support for this.

@jdubois
Copy link
Member Author

jdubois commented May 14, 2021

Indeed, we could have deployment inside the JDL.

Now, just to explain you how it works with https://nubesgen.com/ -> if you select the "GitOps" option, the whole deployment is set up for you using GitHub Actions.
I believe this is the best solution for JHipster. The cloud provider is responsible for:

  • Testing his Terraform config
  • Deploying the final app to this config

This goes much farther to what we currently do with JHipster, but most importantly the testing (which costs $$ and is only interesting for the cloud provider) is done and paid by the could provider.

@MathieuAA
Copy link
Member

Interesting :) I'm currently reviewing and updating the deployment part in the JDL. If I can do something to make the addition/update of options easier, I'll do it.

@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-app-service missing location argument for app-insights
6 participants