-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gateway ports syntax for compose #14962
Conversation
Fix port string generation in docker-compose.yml file, supporting app.yml that may contain hostname as well in port-mapping Fix jhipster#14910
Thanks for your contribution, @swarajsaaj! I believe the version number needs to be removed too. That's what @ndeloof did when he fixed my project in oktadev/java-microservices-examples#23. If you want to really test things, we should change all instances of |
The version in docker-compose.yml file is optional after v1.27 Fix jhipster#14910
Thanks @mraible ,
|
The pipelines are failing on adding "docker compose" command in Update: Added a new step in azure pipeline to install 'compose-cli' and its successful now |
Compose CLI is indeed a separate component, that is still beta and won't be installed by default. |
@swarajsaaj Probably. I was motivated to add support for it since |
Reverting to docker-compose for integration tests, as compose-cli (docker compose) is in preview mode and not installed by default. Fix jhipster#14910
Bounty claimed at https://opencollective.com/generator-jhipster/expenses/40709 |
@swarajsaaj : approved |
Fix port string generation in docker-compose.yml file, supporting
app.yml that may contain hostname as well in port-mapping
Fix #14910
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.