Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supress noisy logs on startup in dev profile #15004

Merged
merged 2 commits into from
May 28, 2021

Conversation

atomfrede
Copy link
Member

@atomfrede atomfrede commented May 14, 2021

close #13835
closes #14444

It now looks like this:

image


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@atomfrede atomfrede changed the title supress 'Validato' logs on startup supress noisy logs on startup in dev profile May 14, 2021
@atomfrede
Copy link
Member Author

The failing test is a heap space error, pretty sure it is not related to the change :)

@atomfrede
Copy link
Member Author

In fact its this error:

image

Seems like this is failing for a bit longer. Is anyone aware of a change with regards to jackson or so?

<!-- See https://github.com/jhipster/generator-jhipster/issues/13835 -->
<logger name="Validator" level="INFO"/>
<!-- See https://github.com/jhipster/generator-jhipster/issues/14444 -->
<logger name="_org.springframework.web.servlet.HandlerMapping.Mappings" level="INFO"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo with additional _ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No in fact not. It's a hidden logger that is prefixed with _

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be lets add a comment so no one thinks its a typo 😂

@atomfrede
Copy link
Member Author

Going to merge this to we have this fixed for the next release, which seems to be quite near.

@atomfrede atomfrede merged commit 3fe65ec into jhipster:main May 28, 2021
@atomfrede
Copy link
Member Author

Bounty claimed https://opencollective.com/generator-jhipster/expenses/41604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants